Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mounts to be specified in containers.conf #1584

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jul 25, 2023

We want to allow HPC Customers and others to specify mounts inside of containers.conf, so that they can have a default list of mounts into all of thier containers.

We want to allow HPC Customers and others to specify mounts
inside of containers.conf, so that they can have a default
list of mounts into all of thier containers.

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan
Copy link
Member Author

rhatdan commented Jul 25, 2023

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one small question.
just a small question, there is already containers-mounts.conf, I think its syntax can be easily extended to support type, I wonder if that feature can be reused here instead of implementing new syntax ?

@rhatdan
Copy link
Member Author

rhatdan commented Jul 25, 2023

containers-mounts.conf predates containers.conf and was really only used for injecting RHEL subscriptions into containers.

I would prefer to stick with the --mount options that we use in podman run --mount.

Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM but I prefer an accompanying Podman PR with tests before merging.

docs/containers.conf.5.md Show resolved Hide resolved
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member Author

rhatdan commented Jul 26, 2023

containers/podman#19375 opened to use and test this PR,

@rhatdan rhatdan added the lgtm label Jul 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit ff82985 into containers:main Jul 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants